On 9/17/20 4:38 PM, Joseph Myers wrote:
On Wed, 16 Sep 2020, Martin Sebor via Gcc-patches wrote:
Attached is an updated revision of the patch. Besides the tweaks
above it also contains a cosmetic change to the warning issued
for mismatches in unspecified VLA bounds: it points at the decl
with more of them to guide the user to specify them rather than
make them all unspecified.
The previous version of the patch had a while loop as previously discussed
to handle skipping multiple consecutive cdk_attrs.
+ next = pd->declarator;
+ while (next && next->kind == cdk_attrs)
+ next = next->declarator;
This version is back to an "if", but I don't see anything else in the new
version of that function that actually means the "if" would skip multiple
consecutive cdk_attrs as desired.
The patch is OK with the "while" restored there. If for some reason the
"while" breaks something, we'll need to look in more detail at exactly
what case isn't being handled correctly by "while".
I guess it was the result of an experiment, trying to see if I could
break it with the 'if'. I (hope I) put it back and pushed the whole
series. I had to squash patches 1 and 2 because of a dependency that
I had missed.
Thanks for the review, by the way. I think the signature validation
we've ended up with is quite a bit more comprehensive than the first
attempt.
Martin
