On Wed, Sep 16, 2020 at 02:38:22PM -0400, Nathan Sidwell wrote:
> On 9/16/20 2:31 PM, Jakub Jelinek wrote:
> > On Wed, Sep 16, 2020 at 02:11:32PM -0400, Nathan Sidwell wrote:
> > > Jakub,
> > > are you ok with the bool return from cp_check_omp_declare_reduction? That
> > > seemed like the least invasive change.
> > >
> > > This corrects the earlier problems with removing the template header
> > > from local omp reductions. And it uncovered a latent bug. When we
> > > tsubst such a decl, we immediately tsubst its body.
> > > cp_check_omp_declare_reduction gets a success return value to gate
> > > that instantiation.
> > >
> > > udr-2.C got a further error, as the omp checking machinery doesn't
> > > appear to turn the reduction into an error mark when failing. I
> > > didn't dig into that further. udr-3.C appears to have been invalid
> > > and accidentally worked.
> >
> > The attached patch doesn't match the ChangeLog...
>
> here's the right one, problem with ordering by time or name :(
LGTM, if both make check-c++-all RUNTESTFLAGS='gomp.exp goacc.exp'
in gcc/ and make check RUNTESTFLAGS=c++.exp
in libgomp/ build dirs shows any regressions, no objections.
Jakub
