On 9/16/20 5:32 AM, Segher Boessenkool wrote:
On Tue, Sep 15, 2020 at 08:38:42PM -0500, Bill Schmidt wrote:
The description in rs6000-builtin.def provides for a builtin named
__builtin_altivec_xst_len_r. However, it is hand-defined in
altivec_init_builtins as __builtin_xst_len_r, against the usual naming
practice. Fix that.
Bootstrapped and tested on powerpc64le-unknown-linux-gnu with no
regressions; committed as obvious.
Does no one use this? Should we provide an alias with the old (wrong)
name? What does the documentation say it should be?
It is obvious of course, except for that "might break users' code"
thing ;-)
Sorry, I should have mentioned this. It's unlikely that people are
using the incorrect name, as it is undocumented, and hidden by the
supported overloaded interfaces. The only documented interface is
"vec_xl_len_r", which remains unchanged (and the internal hookup from
that to this is unchanged by the patch).
If anyone's using the undocumented incorrect interface, I'd rather that
get discovered and fixed.
Thanks,
Bill
Segher
