Andrea Corallo <andrea.cora...@arm.com> writes:
> Hi all,
>
> here is the update version of the patch implementing suggestions.
>
> The check for 'vect_need_peeling_or_partial_vectors_p' (and its
> comment) has also been move just before so we can short-circuit the
> partial vector handling if we know we are using full vectors.
>
> Bootstrapped and regtested on aarch64-linux-gnu.
>
> Okay for trunk?
OK with two incredibly petty comments fixed:
> @@ -991,6 +991,51 @@ vect_min_prec_for_max_niters (loop_vec_info loop_vinfo,
> unsigned int factor)
> return wi::min_precision (max_ni * factor, UNSIGNED);
> }
>
> +/* true if the loop needs peeling or partial vectors when vectorized. */
s/true/True/
> @@ -2265,7 +2276,10 @@ start_over:
> this vectorization factor. */
> if (LOOP_VINFO_CAN_USE_PARTIAL_VECTORS_P (loop_vinfo))
> {
> - if (param_vect_partial_vector_usage == 0)
> + /* Don't use partial vectors if we don't need to peel the
> + loop. */
In this position, the comment fits on one line.
(sorry)
I agree the new code generated for the changed tests is either an
improvement or neutral. (Saying that because I wasn't sure at first
about the addressing mode changes.)
Thanks,
Richard
