On Tue, Sep 15, 2020 at 08:32:54AM +0200, Richard Biener wrote: > On Tue, Sep 15, 2020 at 12:06 AM Segher Boessenkool > <seg...@kernel.crashing.org> wrote: > > > > After the previous patch we are left with an unreachable BB. This will > > ICE if either we have -fschedule-fusion, or we do not have peephole2. > > > > This fixes it. Okay for trunk? > > Just delete_unreachable_blocks () would have worked as well?
Bunch of reasons: 1) We might want some other things that cleanup_cfg does. This unreachable block things caused ICEs in some cases, but what else is there; 2) cleanup_cfg (0) is quite cheap anyway; 3) And, it is only run if the compgotos pass did do work; 4) I did not even remember delete_unreachable_blocks existed :-) > Anyway, OK. Thanks, committed. Segher
