On Tue, Sep 15, 2020 at 12:48:59AM +0200, Tobias Burnus wrote:
>       PR fortran/96668
>       * gomp-constants.h (GOMP_MAP_ALWAYS_POINTER_P):

Missing description (Define. ?)
> 
> libgomp/ChangeLog:
> 
>       PR fortran/96668
>       * libgomp.h (struct target_var_desc):
>       * target.c (gomp_map_vars_existing):
>       (gomp_map_fields_existing):
>       (gomp_map_vars_internal):
>       (GOMP_target_enter_exit_data):

Missing descriptions.

> @@ -11030,7 +11034,7 @@ gimplify_omp_taskloop_expr (tree type, tree *tp, 
> gimple_seq *pre_p,
>  /* Gimplify the gross structure of an OMP_FOR statement.  */
>  
>  static enum gimplify_status
> -gimplify_omp_for (tree *expr_p, gimple_seq *pre_p)
> +gimplify_omp_for (tree *expr_p, gimple_seq *pre_p, bool openacc)
>  {
>    tree for_stmt, orig_for_stmt, inner_for_stmt = NULL_TREE, decl, var, t;
>    enum gimplify_status ret = GS_ALL_DONE;

Wouldn't it be easier to not add an argument, but:
  bool openacc = TREE_CODE (*expr_p) == OACC_LOOP;
inside of the routine?

Otherwise LGTM.

        Jakub

Reply via email to