On Fri, Sep 11, 2020 at 04:24:42PM +0200, Tom de Vries wrote: > I've got an updated version of this patch. It: > - no longer supplies the __atomic_load_16, since that's now handled by > libatomic > - the __sync_val_compare_and_swap now uses __atomic_compare_and_swap, > which also falls back on libatomic. > > I'm currently retesting. > > Any comments? > > Otherwise, I'll commit on Monday.
If some functions are now in libatomic, do we expect users to know that and pass -foffload=-latomic to link, or will mkoffload or whatever do that automatically? If the latter, will e.g. libgomp testsuite ensure that during testing the library can be found even non-installed, if the former, will libgomp testsuite add it for the respective testcases that need it, perhaps under special options? Jakub