Andrea Corallo <andrea.cora...@arm.com> writes:

> Andrea Corallo <andrea.cora...@arm.com> writes:
>
>> Hi Alex,
>>
>> Looking at the code I believe all these casts are meant to be supported
>> (read your intuition was correct).
>>
>> Also IMO source of confusion is that the doc is mentioning 'int' and
>> 'float' but I believe would be better to have like 'integral' and
>> 'floating-point' to clearly disambiguates with respect to the C
>> types.
>>
>> AFAIU the set of supported casts should be like:
>>
>>      integral       <-> integral
>>      floating-point <-> floating-point
>>      integral       <-> floating-point
>>      integral       <-> bool
>>      P*             <-> Q*   for pointer types P and Q.
>>
>> I'd propose to install the following patch to make doc and comments
>> homogeneous at documenting what do we accept, and I guess we should just
>> consider bugs if some of these conversions is not handled correctly or
>> leads to ICE.
>>
>> Bests
>>
>>   Andrea
>>
>> gcc/jit/ChangeLog
>>
>> 2020-07-21  Andrea Corallo  <andrea.cora...@arm.com>
>>
>>      * docs/_build/texinfo/libgccjit.texi (Type-coercion): Improve doc
>>      on allowed type casting.
>>      * docs/topics/expressions.rst (gccjit::context::new_cast)
>>      (gcc_jit_context_new_cast): Likewise.
>>      * libgccjit.c: Improve comment on allowed type casting.
>>      * libgccjit.h: Likewise
>>
>> From 914b9e86808c947d4bb2b06c6960fd8031125f67 Mon Sep 17 00:00:00 2001
>> From: Andrea Corallo <andrea.cora...@arm.com>
>> Date: Tue, 21 Jul 2020 20:12:23 +0200
>> Subject: [PATCH] libgccjit: improve documentation on type conversions

[...]

> Ping
>
> Thanks
>   Andrea

Ping

Reply via email to