Hi! On Tue, Sep 01, 2020 at 12:00:50PM -0500, Peter Bergner wrote: > When we expand our MMA built-ins into gimple, we (me!) erroneously reused > the accumulator memory reference for both the source input value as well as > the destination output value. This led to a tree sharing error. > The solution is to create separate memory references for the input > and output values. > > I'll note that the old build1 call is not actually needed. I believe I > started using that first and then noticed that didn't work in call cases, > so I used build_simple_mem_ref in the other cases. I should have noticed > that build_simple_mem_ref worked for all cases. :-)
So... simple! > This passed bootstrap and regtesting on powerpc64le-linux with no regressions. > Raji has also done some runtime testing of her MMA tests using this patch > and they all showed no regressions either. Ok for trunk and GCC 10 after > a couple of days of burn in? Okay for both. Thanks! Segher
