Hu Jiangping <hujiangp...@cn.fujitsu.com> writes:
> Hi,
>
> This patch add 'cd' command before 'make check-gcc' command
> when run the testsuite on selected tests.
>
> I think the implicit meaning of the original text is to
> execute the cd command to move to the gcc subdirectory of
> the object directory before executing the make command.
> However, due to the following reasons, it may cause
> confusion if it is not clearly written.
>
> * make check-gcc command also can be executed in
> object directory which will run more testcases
> than be executed in gcc subdirectory.
> * the make check-g++ command below will report
> 'No rule to make target' error if be executed in
> object directory.
>
> Tested on x86_64. OK for master?
I think the text above was trying to restrict this to objdir/gcc:
In order to run sets of tests selectively, there are targets
@samp{make check-gcc} and language specific @samp{make check-c},
@samp{make check-c++}, @samp{make check-d} @samp{make check-fortran},
@samp{make check-ada}, @samp{make check-objc}, @samp{make check-obj-c++},
@samp{make check-lto}
in the @file{gcc} subdirectory of the object directory.
but I agree it would be good for clarity and emphasis to have the cd in
the example as well. But if we do that, I think it would be better to
add the cd to the make check-g++ examples too, since I'm not sure the
examples were supposed to be executed in sequence.
It's also a bit inconsistent that the text quoted above uses “check-c++”
while the examples use “check-g++”. The two are equivalent, but it
would be better for the examples to match the text.
Thanks,
Richard
>
> Regards!
> hujp
>
> ---
> gcc/doc/install.texi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
> index 5330bf3bb29..fd4409921ee 100644
> --- a/gcc/doc/install.texi
> +++ b/gcc/doc/install.texi
> @@ -2975,6 +2975,7 @@ A more selective way to just run all @command{gcc}
> execute tests in the
> testsuite is to use
>
> @smallexample
> +cd @var{objdir}/gcc
> make check-gcc RUNTESTFLAGS="execute.exp @var{other-options}"
> @end smallexample
