On Tue, Aug 04, 2020 at 03:53:50PM -0700, Mike Stump wrote:
> On Aug 4, 2020, at 3:16 PM, Marek Polacek via Gcc-patches 
> <gcc-patches@gcc.gnu.org> wrote:
> > 
> > The benefit of dg-accepts-invalid was that you would
> > get an XPASS even for a test that should not be accepted, but you didn't 
> > know
> > what line to expect an error on, so you put a dg-error at the end of the 
> > test.
> 
> I think for most cases it's easy enough to figure out where the error goes.  
> I do see the subtly of the dg-accepts-invalid directive now in the harder 
> cases.  A change of state of them by the new error message I'd like to think 
> is enough to get the people to look at the test case and the corresponding 
> bug report.  I'd propose seeing if people don't also push along the bug in 
> that sort of complex case, I think they will.

You're probably right.  Let's go ahead without dg-accepts-invalid for now and
perhaps reconsider later.

Marek

Reply via email to