On Mon, Aug 3, 2020 at 10:28 AM Andreas Schwab <sch...@linux-m68k.org> wrote: > > On Aug 03 2020, Ian Lance Taylor wrote: > > > On Sun, Aug 2, 2020 at 12:50 AM Andreas Schwab <sch...@linux-m68k.org> > > wrote: > >> > >> This breaks ia64-linux. According to > >> arch/ia64/kernel/syscalls/syscall.tbl, the getrandom syscall is 315 and > >> copy_file_range is 323. > >> > >> ../../../libgo/go/internal/syscall/unix/copy_file_range_linux.go:13:42: > >> error: reference to undefined name 'copyFileRangeTrap' > >> 13 | r1, _, errno := syscall.Syscall6(copyFileRangeTrap, > >> | ^ > >> ../../../libgo/go/internal/syscall/unix/getrandom_linux.go:35:41: error: > >> reference to undefined name 'getrandomTrap' > >> 35 | r1, _, errno := syscall.Syscall(getrandomTrap, > >> | ^ > >> make[4]: *** [internal/syscall/unix.lo] Error 1 > >> make[4]: *** Waiting for unfinished jobs.... > > > > Thanks. Fixed like so. Committed to mainline. > > Actually, on ia64 syscall numbers are offset by 1024, thus the correct > numbers are 1339 and 1347.
Ah ha. I wondered why the number for the getrandom syscall was different. I committed this patch. Ian
76eb0434a40f44f3f9c8a81cf22f56bbeccad12a diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index 39849522124..0bc8e1b5a59 100644 --- a/gcc/go/gofrontend/MERGE +++ b/gcc/go/gofrontend/MERGE @@ -1,4 +1,4 @@ -82a0db12bcb205748a5319b03e070d5502246ba7 +7f0d3834ac40cf3bcbeb9b13926ab5ccb2523537 The first line of this file holds the git revision number of the last merge done from the gofrontend repository. diff --git a/libgo/go/internal/syscall/unix/sysnum_linux_ia64.go b/libgo/go/internal/syscall/unix/sysnum_linux_ia64.go index bb7c363cdc2..6a5d0c90fbe 100644 --- a/libgo/go/internal/syscall/unix/sysnum_linux_ia64.go +++ b/libgo/go/internal/syscall/unix/sysnum_linux_ia64.go @@ -5,6 +5,6 @@ package unix const ( - getrandomTrap uintptr = 315 - copyFileRangeTrap uintptr = 323 + getrandomTrap uintptr = 1339 + copyFileRangeTrap uintptr = 1347 )