Hi Mark,

LOGICAL values fit regardless of kind so warnings are unnecessary. The PR referred to the warning produced for -Wconversion.  This patch also suppresses the warning for -Wconversion-extra.

-Wconversion produces

"Possible change of value in conversion from LOGICAL(4) to LOGICAL(1) ..."

-Wconversion-extra produces

"Conversion from LOGICAL(4) to LOGICAL(1) ..."

Should both warnings be suppressed or just the warning in the original PR?

Both, definitely.

Note: both messages are missing when -Wconversion -Wconversion-extra are used with the gfortran-9 branch.

So, OK for trunk and to gcc-10 (if it also affects that one).

Thanks for the patch!

Regards

        Thomas

Reply via email to