Hi!

Just some random comments...

On Thu, Jul 23, 2020 at 04:44:21PM +0800, Hu Jiangping wrote:
> +      // fix PR96247

      /* See PR96247.  */

> +      if (0 == atoi(arg)) {

Either

      if (atoi (arg) == 0)
        {
          blalalala

or

      if (!atoi (arg))
        {
          blalalala

(whichever reads best in this context).

> +      // fix PR96247

Repeating that many times isn't helping the reader...  It isn't
particularly useful even a single time, anyway?  It is clear what this
does, and if anyone wants to see history, we have Git.


Segher

Reply via email to