Hi!
It's been a while... ;-)
On 2012-06-26T11:29:44-0700, Janis Johnson <janis_john...@mentor.com> wrote:
> Procedure scan-dump-times in scandump.exp uses a printable version of
> the scanned pattern in the line reported to the test summary but others
> in that file don't. This patch fixes that in the remaining procedures
> in scandump.exp. The primary advantage of using the printable pattern
> is with patterns that include newlines, to keep the pattern all on the
> same line in the test summary.
>
> Tested on i686-pc-linux-gnu for gcc and g++. OK for trunk?
This commit, r188996, contained a typo:
> --- lib/scandump.exp (revision 188974)
> +++ lib/scandump.exp (working copy)
> + set printable_pattern [make_pattern_printable [lindex $args 1]]
Not here...
> + set printable_pattern [make_pattern_printable [lindex $args 1]]
..., and not here...
> + set printable_pattern [make_pattern_printable [lindex $args 1]]
..., and not here...
> + set printable_pattern [make_pattern_printable [lindex $args 1]
..., but here, in 'scan-dump-dem-not'.
If I got my greping right, nothing has actually ever used (any of?) the
"demangled" scanning, so we might as well remove it as unused?
Anyway, I shall in a while add a testcase that does use it (... but just
to test all available variants), so, as obvious, pushed commit
3407bfc136bb6b9cf8e25eb753b448b527590b3b "[testsuite] Fix TCL syntax
error in 'scan-dump-dem-not'" to master branch, see attached.
Grüße
Thomas
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander
Walter
>From 3407bfc136bb6b9cf8e25eb753b448b527590b3b Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <tho...@codesourcery.com>
Date: Tue, 30 Jun 2020 07:18:19 +0200
Subject: [PATCH] [testsuite] Fix TCL syntax error in 'scan-dump-dem-not'
ERROR: [...]: error executing dg-final: missing close-bracket
Bug introduced in commit 2ef1bce664881cd59dac7db6c3f3b5709d858bfe (r188996),
long ago.
gcc/testsuite/
* lib/scandump.exp (scan-dump-dem-not): Fix TCL syntax error.
---
gcc/testsuite/lib/scandump.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/lib/scandump.exp b/gcc/testsuite/lib/scandump.exp
index 6cb208f1cef..1cf1559cfff 100644
--- a/gcc/testsuite/lib/scandump.exp
+++ b/gcc/testsuite/lib/scandump.exp
@@ -301,7 +301,7 @@ proc scan-dump-dem-not { args } {
set testcase [testname-for-summary]
# The name might include a list of options; extract the file name.
set filename [lindex $testcase 0]
- set printable_pattern [make_pattern_printable [lindex $args 1]
+ set printable_pattern [make_pattern_printable [lindex $args 1]]
set suf [dump-suffix [lindex $args 2]]
set testname "$testcase scan-[lindex $args 0]-dump-dem-not $suf \"$printable_pattern\""
set src [file tail $filename]
--
2.17.1
