Tamar Christina <tamar.christ...@arm.com> writes:
> Hi Richard,
>
> I have fixed the formatting issues and made it so it checks explicitly
> for ':'.
>
> Ok for master, GCC 10, 9 and 8 after some stew?
OK, thanks. Some trivial formatting bits below (sorry)…
> diff --git a/gcc/config/aarch64/driver-aarch64.c
> b/gcc/config/aarch64/driver-aarch64.c
> index
> d1229e676806f9607c258e5d678fb3175fadf1c2..18d670a1c584d3e6991fea4821bbf6dd394fca0c
> 100644
> +/* Splits and returns a string based on whitespace and return it as
> + part of a set. Empty strings are ignored. */
> +
> +static void
> +split_words (const std::string &val, std::set<std::string> &result)
> +{
> + size_t cur, prev = 0;
> + std::string word;
> + while ((cur = val.find_first_of (" \n", prev)) != std::string::npos)
> + {
> + word = val.substr (prev, cur - prev);
> + /* Skip adding empty words. */
> + if (!word.empty ())
> + result.insert (word);
> + prev = cur + 1;
> + }
”}” should be indented two more spaces.
> + do
> + {
> + size += buf_size;
> + buf = (char*)xrealloc (buf, size);
Should be a space before “xrealloc”.
> + gcc_assert (buf);
> + fgets (buf + last, buf_size, f);
> + /* If we're not at the end of the line then override the
> + \0 added by fgets. */
> + last = strlen (buf) - 1;
> + } while (!feof (f) && buf[last] != '\n');
The brace block should be indented two spaces relative to the “do”,
with the “while” on its own line:
do
{
}
while (…);
> + /* Iterate till the first feature isn't found or all of them
> + are found. */
> + for (it = tokens.begin (); enabled && it != tokens.end (); ++it)
> + enabled = enabled && features.count (*it);
Line indented one space too many.
