On Thu, Jul 16, 2020 at 7:39 PM Nathan Sidwell <nat...@acm.org> wrote:
>
> On 7/16/20 11:56 AM, Iain Sandoe wrote:
> > Hello folks,
>
> It's unfortunate the original plan of handling lifetime issues in a
> gimple pass didn't work out.
>
> > OK for master?
> >
> > OK for 10.x?
IMHO too big of a change for 10.2 but of course fine after the
10.2 release which gives it some beating-time on trunk as well.
Richard.
> ok, some nits
> > +struct interesting
> > +{
>
> not a very good name. As it's not in an anonumous namespace, it has
> external linkage, and hence ripe for ODR breakage, if some other TU is
> interested about something else :) Is there a more specific name it
> could have?
>
>
> > + else if ((tmp_target_expr_p (expr)
> > + && !p->temps_used->contains (expr)))
>
> too many parens here.
>
> nathan
>
> --
> Nathan Sidwell
