Hi! On Wed, Jul 08, 2020 at 12:59:00PM -0700, Carl Love wrote: > [PATCH 2/6] rs6000 Add vector insert builtin support
> +For little-endian, > +the generated code will be semantically equivalent to vinsbrx, vinshrx, > +or vinswrx instructions. Similarly for big-endian it will be semantically > +equivalent to vinsblx, vinshlx, vinswlx. "This builtin generates vins[bhw]lx on BE" etc.? > Note that some > +fairly anomalous results can be generated if the byte index is not aligned > +on an element boundary for the sort of element being inserted. This is a > +limitation of the bi-endian vector programming model. Yeah, leave this out, like Will says? (Also, two spaces after dot.) > +For little-endian, the code generation will be semantically equivalent to > +vins*lx, while for big-endian it will be semantically equivalent to vins*rx. Similar / same as above. This is okay for trunk (with that improved a bit, also the typos and other doc things Will found). Thanks! Segher
