On Fri, 3 Jul 2020 17:41:12 +0200 Thomas Schwinge <tho...@codesourcery.com> wrote:
> Hi Julian! > > On 2020-06-30T15:51:14+0200, I wrote: > > On 2020-06-16T15:38:33-0700, Julian Brown <jul...@codesourcery.com> > > wrote: > >> This is a new version of the patch last sent here: > >> > >> https://gcc.gnu.org/pipermail/gcc-patches/2020-May/546332.html > >> > >> Minus the bits that Thomas has committed already (thanks!), and > >> with adjustments to allow for GOMP_MAP_ATTACH being grouped > >> together with a preceding clause. > >> > >> OK? > > > > Please also update the "virtual refcount" comment in > > 'libgomp.oacc-c-c++-common/structured-dynamic-lifetimes-4.c'. > > > > Your patch now makes the > > 'libgomp.oacc-fortran/mdc-refcount-1-1-1.f90', > > 'libgomp.oacc-fortran/mdc-refcount-1-2-1.f90', > > 'libgomp.oacc-fortran/mdc-refcount-1-2-2.f90', > > 'libgomp.oacc-fortran/mdc-refcount-1-3-1.f90' test cases PASS (did > > you not see that?) > > Ah, you said "Tested (as a series)", so that's probably why I saw this > intermediate step but you didn't. > > > so we have to remove all XFAILing, 'print'/'dg-output' > > etc. from these, and it changes the error reporting in > > 'libgomp.oacc-fortran/mdc-refcount-1-4-1.f90', so we have to adjust > > that. See attached patch "into Adjust dynamic reference count > > semantics". > > Given my recent "[OpenACC] Revert always-copyfrom behavior for > 'GOMP_MAP_FORCE_FROM' in > 'libgomp/oacc-mem.c:goacc_exit_data_internal'", > <87wo3ky5vn.fsf@euler.schwinge.homeip.net">http://mid.mail-archive.com/87wo3ky5vn.fsf@euler.schwinge.homeip.net>, > please also include the attached "into 'Adjust dynamic reference > count semantics': un-XFAIL 'libgomp.oacc-c-c++-common/pr92843-1.c'". > > > > Your patch regresses the attached > > 'libgomp.oacc-c-c++-common/struct-3-1-1.c' > > That was confusing: that's a new test case, not yet in tree. I've posted a new version of the patch here that (hopefully!) addresses all review comments: https://gcc.gnu.org/pipermail/gcc-patches/2020-July/549774.html Thanks, Julian
