Mark,
A quick test with
const char hint [] = _(" [see %<-fno-allow-invalid-boz%>]");
reproduces the failure.
const char *hint = _(" [see %<-fno-allow-invalid-boz%>]");
seems to work. I will do a full bootstrap test with that change later today.
Do you want me to commit it if it works or do you want me to report it to you?
Thanks, David
On Thu, Jul 2, 2020 at 9:38 AM David Edelsohn <dje....@gmail.com> wrote:
>
> On Thu, Jul 2, 2020 at 8:56 AM Mark Eggleston
> <mark.eggles...@codethink.co.uk> wrote:
> >
> > On 02/07/2020 13:25, David Edelsohn wrote:
> > > On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston
> > > <mark.eggles...@codethink.co.uk> wrote:
> > >> I've committed the change from array to pointer. Does this fix your
> > >> builds?
> > >>
> > >> On 02/07/2020 08:18, Mark Eggleston wrote:
> > >>> On 01/07/2020 20:07, David Edelsohn wrote:
> > >>>> This patch breaks bootstrap.
> > >>> Apologies. I didn't see this when I built the compiler the with
> > >>> bootstrap on x86_64. I'll endevour to get it fixed as soon as possible.
> > > Mark,
> > >
> > > Your change did nothing because I previously had removed the
> > > translation markers to restore bootstrap. You were not sufficiently
> > > observant to check the ChangeLog or notice that the line already was
> > > changed.
> > >
> > > Please stop making random, untested changes. This is inappropriate
> > > for GCC development.
> > OK. I had no way of confirming as the bootstrap worked for me. I naively
> > thought that it was covered as an "obvious" fix.
> >
> > I was concerned that I caused a breakage and wanted to fix it.
> >
> > Regarding the ChangeLog I was unfamiliar with this situation and will
> > check them if this ever happens again (I hope not). I'll also keep
> > portability issues in mind.
> >
> > I see the issue of the incorrect hint text has been addressed. As I
> > understand it the string as is will not make it to the pot file so will
> > not be translated, is that acceptable? I would like to be able to close
> > the PR.
>
> Mark,
>
> I reverted your change for that one line to restore bootstrap for
> everyone because Trunk should not be broken for 6 hours and it was
> trivial to revert that one, localized change without affecting the
> rest of your patch.
>
> The translation message for hint should be in the pot file
> translation. This needs to be fixed correctly.
>
> I would suggest that you restore your original change and work to
> reproduce the failure. I don't know if you were not building with NLS
> or had some other local configuration. It seems that
>
> hint[] = _("...")
>
> cannot be valid C syntax unless _( ... ) is a no-op in your build and
> the compiler sees a constant string. The failure occurred for many
> other developers.
>
> Thanks, David
