On Mon, 29 Jun 2020 at 00:16, Jonathan Wakely <jwak...@redhat.com> wrote: > >Hmm, let's use dg-additional-options here too, and axe the pointless > >-std=gnu++11. > > I agree the -std=gnu++11 isn't needed, but thre doesn't seem to be any > advantage to dg-additional-options here. The reason I suggested it for > th other tests was that it can take a target selector, so it can be > used to add options for some targets only (in the case of the variant > tests, only if the dialect is c++17 or later). > > Here you want the -Wnonnull added unconditionally, with no target > selector, so dg-options works fine.
Right, I somehow managed to think that dg-additional-options amends options and dg-options overrides them. Here my intent is certainly the former.
