On Thu, Jun 25, 2020 at 12:09:41PM -0500, Segher Boessenkool wrote:
> Hi!
>
> On Thu, Jun 04, 2020 at 01:03:51PM -0400, Michael Meissner wrote:
> > [PATCH 5/7, V2] PowerPC tests: Prefixed insn with large offsets
> >
> > Add tests to make sure for -mcpu=future that prefixed load/store
> > instructions
> > are generated if the offset is larger than 16 bits. The only difference
> > is I reworded the comments, based on a suggestion by Will Schmidt.
>
> That is the difference to v1? Please mark this up clearly -- there are
> many examples of how you can do this, on the GCC lists even.
>
> > +/* { dg-final { scan-assembler-times {\mpaddi\M|\mpli|\mpla\M} 3 } } */
>
> Is there are reason you don't have \M on pli, or is that an oversight?
Just an oversight.
> Okay for trunk with that looked at, and the necessary "no future"
> changes (and retesting ofc). Thanks!
I simplified the test to use just the instruction (PLI) that is currently
generated. I was just trying to be general to accomidate possible future code
generation changes (i.e. instead of loading up the offset with PLI, we could
potentionally do a PADDI to the base register that was loaded), but we can
change the test if/when we change the compiler.
The test in question was for loading up _Decimal32, which we don't have a
D*-form instruction that we can use, and we must always do an X-form
instruction to load up the 32-bit value into the vector register.
--
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meiss...@linux.ibm.com, phone: +1 (978) 899-4797
