Hello,
On Fri, Jun 26, 2020 at 5:03 AM Jakub Jelinek <ja...@redhat.com> wrote:
> Thanks, just nits, no need to repost, just commit it after you make those
> changes.
>
> On Thu, Jun 25, 2020 at 05:58:23PM -0400, y2s1982 via Gcc-patches wrote:
>
> > * Makefile.am(toolexeclib_LTLIBRARIES): Add libgompd.la.
>
> Missing space between am and (.
>
> > * env.c(ompd_dll_locations_valid): Define with no compiler
> optimization.
>
> Again, missing space.
>
> The contrib/mklog.py, which I use to generate these messages, seems to
generate the statement without a space after the filename and before the (.
It seems like an easy fix of just adding a space like the following:
diff --git a/contrib/mklog.py b/contrib/mklog.py
index 243edbb15c5..0b01cde6fca 100755
--- a/contrib/mklog.py
+++ b/contrib/mklog.py
@@ -215,7 +215,7 @@ def generate_changelog(data, no_functions=False,
fill_pr_titles=False):
if functions:
out += '\t* %s (%s):\n' % (relative_path,
functions[0])
for fn in functions[1:]:
- out += '\t(%s):\n' % fn
+ out += '\t (%s):\n' % fn
else:
out += '\t* %s:\n' % relative_path
out += '\n'
Would it be okay for me to make this patch? I wasn't sure of the exact
procedure that I might have to do prior to sending in a patch.
Cheers,
Tony Sim
> Jakub
>
>
