On Thu, Jun 25, 2020 at 06:54:26PM -0500, Segher Boessenkool wrote:
> Hi!
>
> On Thu, Jun 25, 2020 at 06:36:51PM -0500, Peter Bergner wrote:
> > rs6000: Add support for __builtin_cpu_is ("power10")
> >
> > Add support for __builtin_cpu_is ("power10"). Also add documentation for
> > the recently added "arch_3_1" and "mma" __builtin_cpu_supports arguments.
>
> > gcc/
> > * config/rs6000/rs6000-call.c (cpu_is_info) <power10>: New.
> > <mma>: Remove unneeded ','.
>
> The comma helps making the diff less for future additions (and, makes
> merging/refactoring easier, that way). A trailing comma was not allowed
> with older C standards (or just with some implementations?), but it
> should be fine with C++11 as we require now. Is there something I am
> missing here?
A trailing comma has always been allowed for structure and array
initializations. Where it is not allowed is for enumeration names.
--
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meiss...@linux.ibm.com, phone: +1 (978) 899-4797
