On Wed, Jun 24, 2020 at 09:15:57AM +0000, zhoukaipeng (A) wrote: > Hi, > > This is a fix for pr95854. > > Only add a judgement to make sure operand1 and operand2 are both INTEGER_CST.
So what are those two operands then when not INTEGER_CSTs? POLY_INT_CSTs? The documentation says: operand 1 is a tree giving the constant number of bits being referenced; operand 2 is a tree giving the constant position of the first referenced bit. The ChangeLog is incorrect, it should say: * gimple-ssa-store-merging.c (find_bswap_or_nop_1): Return NULL if operand 1 or 2 of a BIT_FIELD_REF are not INTEGER_CSTs. and patch should not be modifying ChangeLog files, the ChangeLog entry belongs now solely into the commit message from which a script adds it to ChangeLog files later. Jakub