On Wed, Jun 24, 2020 at 10:49 AM Martin Liška <mli...@suse.cz> wrote: > > On 6/24/20 9:43 AM, Richard Biener wrote: > > Hmm, can you instead use simple_dce_from_worklist and simply > > record all SSA_NAMEs you end up "forwarding" as possibly dead > > in a bitmap? At least that hashmap traversal looks dangerous > > with respect to address-space randomization and gsi_remove > > inserting debug stmts and thus eventually allocating debug decls. > > Sure, done in the updated patch.
You can simplify the patch by eliding the num_imm_uses checks and by using auto_bitmap. Why is it necessary to update the veclower pass btw? Is that just to avoid useless isels on dead code? You also updated veclower "nicely" but still have the hashmap walk in isel - you should know when you "merged" a condition into a cond and set the bit there. Richard. > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin >
