Hi!

On Mon, Jun 15, 2020 at 04:37:47PM -0700, Carl Love wrote:
>         * config/rs6000/altivec.md: (UNSPEC_EXTRACTL, UNSPEC_EXTRACTR)

No colon here.

>       (vextractl<mode>, vextractr<mode>)
>         (vextractl<mode>_internal, vextractr<mode>_internal)
>       (VI2): Move to gcc/config/rs6000/vsx.md.

Will explained how you can easily write a changelog entry for moving
code to another file.

If you write <mode> in a changelog left side of a colon, it usually
helps to say what iterator that is: "<mode> for VI2" for example.  This
is of course more important in more complex cases, say where you have
the exact same names just for different iterators, or when you have
<code> for example (the name "<code><mode>3" is really not very
enlightening :-) )

>       * config/rs6000/vsx.md: (UNSPEC_EXTRACTL, UNSPEC_EXTRACTR)

No colon.

>         (vextractl<mode>, vextractr<mode>)
>         (vextractl<mode>_internal, vextractr<mode>_internal)
>       (VI2): Code was moved from config/rs6000/altivec.md.
>       * gcc/doc/extend.texi: Update documentation for vec_extractl.
>       Replace builtin name vec_extractr with vec_extracth.  Update description
>       of vec_extracth.

The indent is weird in places, I guess that is just a mail issue.

Okay for trunk with those trivialities, and the things Will found, fixed
up.  Thanks!  Just writing out the full instruction names is the easiest
for everyone btw, unless that then needs to be a huge list, that isn't
very helpful to anyone.


Segher

Reply via email to