On Thu, Jun 18, 2020 at 10:21:00AM +0200, Martin Liška wrote: > All right, let's do it better.
Thanks! (Btw, the MIME sub-type of "x-patch" makes this unviewable on many browsers, in the gcc-patches@ archive (and unusable in many mail clients of course). Anything "x-*" should never be used on public mailing lists, or anywhere else where you didn't get all people receiving this to agree what this type means). > >From 9ba94cec649ef84399531f43d5c7171328a3f704 Mon Sep 17 00:00:00 2001 > From: Martin Liska <mli...@suse.cz> > Date: Thu, 18 Jun 2020 09:25:32 +0200 > Subject: [PATCH] rs6000: fix creation of VEC_COND_EXPR Capital F on Fix. Easy check is to run "git log --oneline" and see if your commit seems out of place ;-) > * config/rs6000/rs6000-call.c (fold_build_vec_cmp): > Since 502d63b6d6141597bb18fd23c87736a1b384cf8f, first argument > of a VEC_COND_EXPR cannot be tcc_comparison and so that > a SSA_NAME needs to be created before we use it for the first > argument of the VEC_COND_EXPR. This isn't documented (in generic.texi). Please fix that? (In a separate patch of course.) > @@ -10714,16 +10714,19 @@ rs6000_builtin_valid_without_lhs (enum > rs6000_builtins fn_code) > operation. This sets up true/false vectors, and uses the > VEC_COND_EXPR operation. > CODE indicates which comparison is to be made. (EQ, GT, ...). > - TYPE indicates the type of the result. */ > + TYPE indicates the type of the result. (trailing spaces) > + GSI points to a GIMPLE statement that we are currently folding. */ That isn't a useful thing to say. Write that this function inserts new code before there? Okay for trunk with those changes. Thanks! Segher
