Richard Biener <rguent...@suse.de> writes:
> On Thu, 18 Jun 2020, Jakub Jelinek wrote:
>
>> Hi!
>> 
>> As the following testcase shows, the exception for the aarch64
>> vec_pack_trunc_di is not sufficient on x86, the halfvectype
>> "vectors" have SImode but the x86 vec_pack_trunc_si meant for
>> the bool bitmasks combines 2x SImode into DImode, while in the
>> testcase the halfvectype is 1x SImode "vector" with SImode and
>> result is 2x HImode "vector" with SImode.
>> 
>> The patch also verifies the result mode.  The other option is
>> to throw away the aarch64 exception.  And yet another option
>> would be to use different optabs for vector bools with integral modes.
>> 
>> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/10.2?
>
> OK.

FWIW, since the aarch64 case was only found by inspection and might
not be useful, personally I'd prefer to drop that case after all.

Thanks,
Richard

Reply via email to