Hi!
On 2020-04-29T16:01:56+0200, Tobias Burnus <tob...@codesourcery.com> wrote:
> See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94848
>
> The problem is a generated static array variable in the
> device function:
> static integer(kind=4) A.12[3] = {1, 2, 3};
> used as
> _26 = A.12[S.13_67];
>
> [...]
..., and that PR was recently fixed, and so...
> On 4/29/20 12:00 PM, Thomas Schwinge wrote:
>> On 2020-01-08T09:55:06+0100, Tobias Burnus <tob...@codesourcery.com> wrote:
>>> On 1/8/20 9:33 AM, Thomas Schwinge wrote:
>>>> With 'dg-do run' added, on [...] x86_64-pc-linux-gnu with offloading I'm
>>>> seeing:
>> | PASS: libgomp.fortran/use_device_ptr-optional-3.f90 -O0 (test for
>> excess errors)
>> | PASS: libgomp.fortran/use_device_ptr-optional-3.f90 -O0 execution
>> test
>> | PASS: libgomp.fortran/use_device_ptr-optional-3.f90 -O1 (test for
>> excess errors)
>> | PASS: libgomp.fortran/use_device_ptr-optional-3.f90 -O1 execution
>> test
>> | FAIL: libgomp.fortran/use_device_ptr-optional-3.f90 -O2 (test for
>> excess errors)
>> | UNRESOLVED: libgomp.fortran/use_device_ptr-optional-3.f90 -O2
>> compilation failed to produce executable
>> | FAIL: libgomp.fortran/use_device_ptr-optional-3.f90 -O3
>> -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions
>> (test for excess errors)
>> | UNRESOLVED: libgomp.fortran/use_device_ptr-optional-3.f90 -O3
>> -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions
>> compilation failed to produce executable
>> | FAIL: libgomp.fortran/use_device_ptr-optional-3.f90 -O3 -g (test
>> for excess errors)
>> | UNRESOLVED: libgomp.fortran/use_device_ptr-optional-3.f90 -O3 -g
>> compilation failed to produce executable
>> | FAIL: libgomp.fortran/use_device_ptr-optional-3.f90 -Os (test for
>> excess errors)
>> | UNRESOLVED: libgomp.fortran/use_device_ptr-optional-3.f90 -Os
>> compilation failed to produce executable
... that problem now is gone, too. I've thus pushed "Add 'dg-do run' to
'libgomp.fortran/use_device_ptr-optional-3.f90' [PR94848]" to master
branch in commit 5864930754f63e2dcef9606f2514ae20e80f436e, and
releases/gcc-10 branch in commit
61c896d84bdefbfffa7573a8af89119d4db7b3de, see attached.
Grüße
Thomas
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander
Walter
>From 5864930754f63e2dcef9606f2514ae20e80f436e Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <tho...@codesourcery.com>
Date: Tue, 7 Jan 2020 17:40:14 +0100
Subject: [PATCH] Add 'dg-do run' to
'libgomp.fortran/use_device_ptr-optional-3.f90' [PR94848]
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Fix-up for r279858/commit f760c0c77fe350616da9dbeaea16442b0acfb09c "Fortran]
OpenMP/OpenACC – fix more issues with OPTIONAL".
With offloading enabled, we then saw:
PASS: libgomp.fortran/use_device_ptr-optional-3.f90 -O0 (test for excess errors)
PASS: libgomp.fortran/use_device_ptr-optional-3.f90 -O0 execution test
PASS: libgomp.fortran/use_device_ptr-optional-3.f90 -O1 (test for excess errors)
PASS: libgomp.fortran/use_device_ptr-optional-3.f90 -O1 execution test
FAIL: libgomp.fortran/use_device_ptr-optional-3.f90 -O2 (test for excess errors)
UNRESOLVED: libgomp.fortran/use_device_ptr-optional-3.f90 -O2 compilation failed to produce executable
FAIL: libgomp.fortran/use_device_ptr-optional-3.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (test for excess errors)
UNRESOLVED: libgomp.fortran/use_device_ptr-optional-3.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions compilation failed to produce executable
FAIL: libgomp.fortran/use_device_ptr-optional-3.f90 -O3 -g (test for excess errors)
UNRESOLVED: libgomp.fortran/use_device_ptr-optional-3.f90 -O3 -g compilation failed to produce executable
FAIL: libgomp.fortran/use_device_ptr-optional-3.f90 -Os (test for excess errors)
UNRESOLVED: libgomp.fortran/use_device_ptr-optional-3.f90 -Os compilation failed to produce executable
... due to:
/tmp/cciVc43I.o:(.gnu.offload_vars+0x10): undefined reference to `A.12.4064'
[...]
..., but after the recent PR94848, PR95551 changes, that problem is now gone.
libgomp/
PR lto/94848
* testsuite/libgomp.fortran/use_device_ptr-optional-3.f90: Add
'dg-do run'.
---
libgomp/testsuite/libgomp.fortran/use_device_ptr-optional-3.f90 | 1 +
1 file changed, 1 insertion(+)
diff --git a/libgomp/testsuite/libgomp.fortran/use_device_ptr-optional-3.f90 b/libgomp/testsuite/libgomp.fortran/use_device_ptr-optional-3.f90
index f2e1a60757f9..b06a88415b47 100644
--- a/libgomp/testsuite/libgomp.fortran/use_device_ptr-optional-3.f90
+++ b/libgomp/testsuite/libgomp.fortran/use_device_ptr-optional-3.f90
@@ -1,3 +1,4 @@
+! { dg-do run }
! Check whether absent optional arguments are properly
! handled with use_device_{addr,ptr}.
program main
--
2.27.0
>From 61c896d84bdefbfffa7573a8af89119d4db7b3de Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <tho...@codesourcery.com>
Date: Tue, 7 Jan 2020 17:40:14 +0100
Subject: [PATCH] Add 'dg-do run' to
'libgomp.fortran/use_device_ptr-optional-3.f90' [PR94848]
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Fix-up for r279858/commit f760c0c77fe350616da9dbeaea16442b0acfb09c "Fortran]
OpenMP/OpenACC – fix more issues with OPTIONAL".
With offloading enabled, we then saw:
PASS: libgomp.fortran/use_device_ptr-optional-3.f90 -O0 (test for excess errors)
PASS: libgomp.fortran/use_device_ptr-optional-3.f90 -O0 execution test
PASS: libgomp.fortran/use_device_ptr-optional-3.f90 -O1 (test for excess errors)
PASS: libgomp.fortran/use_device_ptr-optional-3.f90 -O1 execution test
FAIL: libgomp.fortran/use_device_ptr-optional-3.f90 -O2 (test for excess errors)
UNRESOLVED: libgomp.fortran/use_device_ptr-optional-3.f90 -O2 compilation failed to produce executable
FAIL: libgomp.fortran/use_device_ptr-optional-3.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (test for excess errors)
UNRESOLVED: libgomp.fortran/use_device_ptr-optional-3.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions compilation failed to produce executable
FAIL: libgomp.fortran/use_device_ptr-optional-3.f90 -O3 -g (test for excess errors)
UNRESOLVED: libgomp.fortran/use_device_ptr-optional-3.f90 -O3 -g compilation failed to produce executable
FAIL: libgomp.fortran/use_device_ptr-optional-3.f90 -Os (test for excess errors)
UNRESOLVED: libgomp.fortran/use_device_ptr-optional-3.f90 -Os compilation failed to produce executable
... due to:
/tmp/cciVc43I.o:(.gnu.offload_vars+0x10): undefined reference to `A.12.4064'
[...]
..., but after the recent PR94848, PR95551 changes, that problem is now gone.
libgomp/
PR lto/94848
* testsuite/libgomp.fortran/use_device_ptr-optional-3.f90: Add
'dg-do run'.
(cherry picked from commit 5864930754f63e2dcef9606f2514ae20e80f436e)
---
libgomp/testsuite/libgomp.fortran/use_device_ptr-optional-3.f90 | 1 +
1 file changed, 1 insertion(+)
diff --git a/libgomp/testsuite/libgomp.fortran/use_device_ptr-optional-3.f90 b/libgomp/testsuite/libgomp.fortran/use_device_ptr-optional-3.f90
index f2e1a60757f9..b06a88415b47 100644
--- a/libgomp/testsuite/libgomp.fortran/use_device_ptr-optional-3.f90
+++ b/libgomp/testsuite/libgomp.fortran/use_device_ptr-optional-3.f90
@@ -1,3 +1,4 @@
+! { dg-do run }
! Check whether absent optional arguments are properly
! handled with use_device_{addr,ptr}.
program main
--
2.27.0
