Hi Andrew, > > > > The amdgcn-amdhsa test seems to be running for all targets > > unconditionally while only really makes sense for certain targets. > > This patch adds an opt-out list and opts out arm targets. > > > > Regtested on aarch64-none-linux-gnu and no issues. > > > > Ok for master? > > I don't think this is right. It does make sense to have aarch64 to support > it as > an offload; though someone needs to test out the GPU card on an ARM64 > server.
That seems contradictory to me. Someone should first test it then enable it. > Maybe checking for *-*-elf *-*-eabi and returning false for those targets > should be enough for most embedded targets. > Ultimately this won't help me. My problem with the test isn't that it's running, It's that it's very very loud. There doesn't seem to be any way to silence the result of the feature check as is done with virtually every other feature check *but* this one. Instead you get xgcc: fatal error: GCC is not configured to support amdgcn-amdhsa as offload target^M compilation terminated.^M compiler exited with status 1 which gets confused with people thinking something is broken. If this feature test can somehow behave like the rest (e.g. don't spit out anything unless -v is passed to dejagnu) then I would be happy. Thanks, Tamar > Thanks, > Andrew Pinski > > > > > Thanks, > > Tamar > > > > gcc/testsuite/ChangeLog: > > > > * lib/target-supports.exp (check_effective_target_offload_gcn): Skip > for > > arm targets. > > > > --
