Hello, Asher Gordon <asd...@posteo.net> writes:
> I also added a note after the warning showing where the field was
> defined in the structure, like this:
>
> inform (DECL_SOURCE_LOCATION (info.field),
> "in definition of %qT", constructor_type);
>
> However, I think it would be preferable to point to the definition of
> the structure itself, since that is where the attribute is. Something
> like this:
>
> inform (DECL_SOURCE_LOCATION (constructor_type),
> "%qT defined here", constructor_type);
>
> Unfortunately, the above does not work since 'constructor_type' is a
> type rather than a variable, and thus DECL_SOURCE_LOCATION does not work
> on it. Do you know if there is something similar to DECL_SOURCE_LOCATION
> that can be used on types like 'constructor_type'?
Actually, even that would not be perfect, because the structure may be
defined somewhere and the attribute applied to it elsewhere, even in a
different file. For example:
struct S {
int foo, bar;
};
struct __attribute__((designated_init)) S;
So it would be better to point to the second declaration of S, because
that is where the attribute is applied. Actually, it would be ideal to
point to the attribute itself, so a note something like the following
could be produced:
test.c:4:22: note: ‘designated_init’ attribute applied here
4 | struct __attribute__((designated_init)) S;
| ^~~~~~~~~~~~~~~
Do you know if that's possible?
Thanks,
Asher
--
"It's my cookie file and if I come up with something that's lame and I like it,
it goes in."
-- karl (Karl Lehenbauer)
--------
I prefer to send and receive mail encrypted. Please send me your
public key, and if you do not have my public key, please let me
know. Thanks.
GPG fingerprint: 38F3 975C D173 4037 B397 8095 D4C9 C4FC 5460 8E68
signature.asc
Description: PGP signature
