Hi Jakub, When I compiled the header after adding the missing typedefs, I got warnings about nothrow attribute being ignored on typedef function declarations. Should I remove them from typedef function declarations?
Cheers, Tony Sim On Sat, Jun 13, 2020 at 10:15 AM y2s1982 . <y2s1...@gmail.com> wrote: > Hi Jakub, > > Thank you for the valuable feedback. I especially liked the tip on how to > compile the header. > I will make a new patch and submit it. > > Cheers, > > Tony Sim > > On Sat, Jun 13, 2020 at 5:13 AM Jakub Jelinek <ja...@redhat.com> wrote: > >> On Sat, Jun 13, 2020 at 11:06:52AM +0200, Jakub Jelinek via Gcc-patches >> wrote: >> > On Fri, Jun 12, 2020 at 07:51:32PM -0400, y2s1982 wrote: >> > > This patch adds a partial omp-tools.h from OpenMP project which >> > > declares function prototypes and typedefs used in OMPD. >> > > >> > > This patch also addressed all feedback. >> > > >> > > 2020-06-12 Tony Sim <y2s1...@gmail.com> >> > > >> > > libgomp/ChangeLog: >> > > >> > > * Makefile.am: Added new header. >> > >> > This should give more details, like: >> > * Makefile.am (nodist_libsubinclude_HEADERS): Add omp-tools.h. >> > >> > > * Makefile.in: Regenerate. >> > > * omp-tools.h: New file. >> > >> > Otherwise LGTM, but as we discussed, for now please push it to your >> > stable repository and we'll put it into GCC mainline when it is complete >> > or at least mostly complete. >> >> Actually, have you tried to compile the header? >> echo '#include "omp-tools.h"' | gcc -S -xc - -o /tmp/omp-tools.s >> ? I think you are missing some typedefs. >> >> E.g. in OpenMP/sources I see >> typedef uint64_t ompd_size_t; >> >> typedef uint64_t ompd_wait_id_t; >> >> typedef uint64_t ompd_addr_t; >> typedef int64_t ompd_word_t; >> typedef uint64_t ompd_seg_t; >> >> typedef uint64_t ompd_device_t; >> and I think from these you only have ompd_wait_id_t... >> For int64_t replacement use __INT64_TYPE__... >> >> Jakub >> >>
