On Jun 9, 2020, Martin Jambor <mjam...@suse.cz> wrote: >> Before your changes, GCC produced the expected: >> >> $ ls -1 build-gcc/gcc/testsuite/brig/variables.*???t.* >> build-gcc/gcc/testsuite/brig/variables.hsail.brig.004t.original >> build-gcc/gcc/testsuite/brig/variables.hsail.brig.005t.gimple >> >> Are you able to easily create a patch for that? How/where to adjust: >> producer-side (GCC driver, or BRIG (HSAIL) front end?), or consumer-side >> (testsuite: tree scanning machinery, or have to put some '-dumpbase' into >> all test case files?)?
> I looked into the issue yesterday and decided the simplest fix is > probably the following. I concur, FWIW. Thanks for looking into it. Since dumpbase is now based on dest rather than src, at least for compilation without linking, a change that aligns source and dest basenames makes for a least-surprise scenario. I suppose we might want to eventually adjust the expectations of dump names in the testsuite to compute names based on outputs rather than inputs, or based on both when compiling and linking, but that will require quite significant internal API changes in the testsuite infrastructure. I'm sort of hoping we can make do with what we got, at least until the new naming conventions are solidly established. > * lib/brig.exp (brig_target_compile): Strip hsail extension when > gnerating the name of the binary brig file. LGTM, thanks. -- Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo/ Free Software Evangelist Stallman was right, but he's left :( GNU Toolchain Engineer Live long and free, and prosper ethically
