Hi Alexandre,
Alexandre Oliva <ol...@adacore.com> wrote:
On Jun 9, 2020, Iain Sandoe <idsan...@googlemail.com> wrote:
I have an ugly patch that makes this work for Darwin (essentially, by
having two versions of the LTO tests
We could deal with that in a similar way to how .dwo files are handled,
namely, with explicit handling in the main test procedure.
perhaps; we’d need to figure out the conditions that hold (presumably, as
I’ve done in the patch in PR95577, make something conditional on c/l opts).
Or, even better, we could introduce an alternate syntax, using a nested
list/pair with condition and file, that would require the file only if
the condition holds.
This could then be used for dwo, for lto, and possibly for other
situations.
that seems nicer - albeit more work.
All that said, I don't object to putting this test machinery to other
uses (hey!, it's Free Software! :-), so if you feel that would be
useful, let's go for it.
Well, I guess I’ve thought for some time that the driver is only tested
in a rather ad hoc manner (e.g. there are tests sprinkled here and there
for Darwin-specific c/l options and relevant output).
In fact, much of the driver’s operation could be verified with the output
of -### .. (but not, unfortunately, when there’s a linker-like sub-process).
——
Thinking things are a good idea is sadly not the same as having time to
address them.
short “shopping list” for this .exp:
what’s noted above ...
.. plus separation of the enumeration and running of the tests so that:
* target-specific exclusions / inclusions can be done with dg-*
* there’s a way to implement RUNTESTFLAGS=outputs.exp=some-test
unless that already works somehow?
====
In the short-term, I think to post/apply the first part of the patch in
PR95577
once you’ve put in the change to exclude LTO (otherwise we get 85 fails on
Darwin).
thanks for adding what’s there - it does cover stuff that had no testing at
all!
cheers
Iain
--
Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo/
Free Software Evangelist Stallman was right, but he's left :(
GNU Toolchain Engineer Live long and free, and prosper ethically
