Hi!

On Mon, Jun 01, 2020 at 09:14:54AM -0700, Carl Love wrote:
>         * config/rs6000/altivec.h: Add define for vec_sldb and
> vec_srdb.

        (vec_sldb, vec_srdb): New defines.

(Etc.)

>         * testsuite/gcc.target/powerpc/vec-shift-double-runnable.c: Add
>         runnable test case.

gcc/testsuite/ has its own changelog.

> +     /* Check whether the 3rd argument is an integer constant in the
> range
> +     0 to 7 inclusive.  */
> +     STRIP_NOPS (arg2);
> +     if (TREE_CODE (arg2) != INTEGER_CST
> +      || !IN_RANGE(TREE_INT_CST_LOW(arg2), 0, 7))

Space before ( please (twice).

The rest looks fine -- either repost this with a better changelog, or
immediately commit it with that (and the nit fixed), whichever you
prefer.  Thanks!


Segher

Reply via email to