On Fri, May 29, 2020 at 1:53 AM MOSER Virginie via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > The assembly code in libgcc/config/riscv/div.S does not handle the division > by zero as specified in the riscv-spec v2.2 chapter 6.2 in case of signed > division:
This looks OK. There are some administrative comments to make here. FSF policy requires copyright assignments. I don't see one for you or your employer. If you are serious about contributing to GNU projects. you need to get a copyright assignment. This patch is small enough that I can accept it, but I may not be able to accept the next one. If you don't get a copyright assignment, you might consider filing bug reports instead and let someone with an assignment write the patch. The patch is mime encoded which is inconvenient. The patch also got corrupted somehow. I had to edit it before I could get it to apply. Or maybe the patch was for an older gcc version? git format-patch and git send-email is a good way to create and send a patch. Or you can file a bug report and add the patch as an attachment there. ChangeLog entries should describe what change was made. Not why it was made. The why should go into the git commit or comments in the code. I rewrote the ChangeLog entry. We prefer lines that are less than 80 characters. I moved the comment to a separate line and also fixed some other nearby lines. Comments end with a period and two spaces. I fixed up the patch, tested it, and committed it. I will send the patch I committed. Jim
