On Sat, 2020-05-30 at 13:40 +0000, Pip Cet via Gcc-patches wrote: > On Fri, May 29, 2020 at 6:21 PM Pip Cet <pip...@gmail.com> wrote: > > IIRC, minimum string alignment does not satisfy the triangle > > inequality anyway, so test_metric_conditions should probably not > > pretend to test it... > > I did remember correctly, though of course that should have been > "optimal string alignment" :-). If you change the spellcheck.c > test_data array to include "abc", "ac", and "ca", the self-test will > fail, even without your patch. > > I think we should just omit the triangle inequality test from the > self-test, as in the attached patch.
I like the idea, but can you update the comment so that it explains why it's not a metric? (better to capture that in a comment in the source rather than just in the mailing list archives). Thanks Dave
