On Wed, 2020-05-27 at 19:05 -0300, Alexandre Oliva wrote:
> outputs.exp: no lto, linker default output, cdtor temps, empty args
>
> From: Alexandre Oliva <ol...@adacore.com>
>
> This patch fixes various issues in the testsuite that came up after
> the dump/aux output revamp, namely:
>
> - many outputs.exp tests used -flto without checking that LTO was
> supported, getting lots of failures. With this patch, we test for LTO
> support, and skip -flto tests on platforms that do not support it.
>
> - some linkers error out if an output file is not named, and the
> a.{out,exe} construct that we used throughout outputs.exp to match the
> default linker output would trigger a bug in tcl globbing. With this
> patch, we detect the default linker output early. If none is found,
> we arrange to pass -o a.out explicitly in tests that used to test the
> default linker output. We now look for the detected default, or for
> explicitly-specified output.
>
> - collect2 will leave <execname>.cdtor.* files behind in -save-temps
> tests. Ignore them.
>
> - The prepending of -Wl, to file names in ldflags et al was done in a
> way that introduced empty arguments when consecutive blanks appeared
> in these board configuration knobs. Skip the empty strings between
> consecutive blanks to avoid this problem.
>
> Tested so far on x86_64-linux-gnu and powerpc-aix7. Ok to install?
>
>
> gcc/testsuite/ChangeLog:
>
> * lib/gcc-defs.exp: Avoid introducing empty arguments between
> consecutive blanks in board linking options.
> * gcc.misc-tests/outputs.exp: Likewise. Document
> -gsplit-dwarf testing, skip LTO tests if -flto is not
> supported, detect the default linker output name, cope with
> the need for an explicit executable output.
OK. THanks for jumping on it quickly. I'll re-enable the tester once the patch
is committed.
jeff
>
