On May 25, 2020 6:31:29 PM GMT+02:00, Segher Boessenkool <seg...@kernel.crashing.org> wrote: >On Mon, May 25, 2020 at 12:46:02PM +0530, kamlesh kumar wrote: >> > OTOH, you don't need to name Tuple at all... It should not *have* >a >> > constructor, since you declared it as class... But you can just >use >> > std::tuple here? >> >> I thought of using std::tuple but it requires c++11 support. >> I am not sure we always build gcc with c++11? > >https://gcc.gnu.org/install/prerequisites.html > >We do for GCC 11 :-) Since we pay the price for progress, let's reap >the >benefits as well :-)
Not sure if the benefit is enough to warrant an extra (complex?) standard header in almost every TU. >> > > (emit_library_call): Added default arg unsigned_p. >> > > (emit_library_call_value): Added default arg unsigned_p. >> > >> > Yeah, eww. Default arguments have all the problems you had before, >> > except now it is hidden and much more surprising. >> > >> > Those functions really should take rtx_mode_t arguments? >> >> I was thinking the same. will incorporate this. > >Thanks! > > >Segher
