On 5/21/20 10:49 AM, Jakub Jelinek wrote:
On Thu, May 21, 2020 at 10:23:38AM +0200, Martin Liška wrote:
Hi.
The patch understand DR entries in git commit messages and
preserve them for ChangeLog entries.
Do you handle other free-style comments above the commit?
No. Note that the PR (and DR now) are markers that identify start of
ChangeLog section in git commit message
I mean, especially in gcc/cp/ Jason, Marek and others use something like:
r11-292-g52c5933f5838adb7bf6035e648b770b4958d137f
Resolve C++20 NB comment CA104
etc.?
Does it work only when one uses the email line in the commit message,
not at all or works fine even without that?
Can you be please more concrete about this?
I've made a quick analysis of cp/ChangeLog entries and I see these
interesting beginnings:
Resolve C++20 NB comment CA104
CWG 2235
Implement P2092R0, Disambiguating Nested-Requirements
P1937R2 - Fixing inconsistencies between const{expr,eval} functions
P1937R2 - Fixing inconsistencies between const{expr,eval} functions
P0780R2: Resolve lambda init-capture pack grammar.
Implement P1946R0, Allow defaulting comparisons by value.
Implement D1957R0, T* to bool should be considered narrowing.
Implement D1959R0, remove weak_equality and strong_equality.
Implement D1907R1 "structural type".
Implement P1286R2, Contra CWG1778
Implement p1301 [[nodiscard("should have a reason")]] + p1771 DR
P1091R3 - Extending structured bindings to be more like var decls
P1381R1 - Reference capture of structured bindings
CWG 2094 - volatile scalars are trivially copyable.
CWG 2096 - constraints on literal unions.
Implement P0634R3, Down with typename!
Implement P1094R2, Nested inline namespaces.
Implement P0479R5, [[likely]] and [[unlikely]].
Remove ovl_used, it is no longer needed
P1236R1 - Signed integers are two's complement
Implement P0315R4, Lambdas in unevaluated contexts.
Implement P0722R3, destroying operator delete.
Implement P0780R2, pack expansion in lambda init-capture.
Implement UDL changes from P0732R2.
Implement P0732R2, class types in non-type template parameters.
Implement P0846R0, ADL and function templates.
Implement P0892R2, explicit(bool).
Implement P0840, language support for empty objects.
Add -Wclass-conversion.
P1064R0 - Allowing Virtual Function Calls in Constant Expressions
P0806R2 - Deprecate implicit capture of this via [=]
P0595R1 - is_constant_evaluated
P1008R1 - prohibit aggregates with user-declared constructors
I'm open for supporting more of these, but I would like to keep it simple as
possible.
Martin
Jakub
