On 5/21/20 1:52 AM, Fangrui Song wrote:
The above issues motivated me to touch this line in PATCH v2. Dropped in PATCH v2.
Thank you for the updated patch. The patch is fine except coding style issues: $ ./contrib/check_GNU_style.py /tmp/0001-Add-fuse-ld-to-specify-an-arbitrary-executable-as-th.patch === ERROR type #1: blocks of 8 spaces should be replaced with tabs (4 error(s)) === gcc/collect2.c:1135:0:████████ld_file_name = find_a_file(&cpath, ld_suffixes[selected_linker], X_OK); gcc/collect2.c:1137:0:████████ for `ld' (if native linking) or `TARGET-ld' (if cross). */ gcc/collect2.c:1139:0:████████ld_file_name = gcc/collect2.c:1140:0:████████ find_a_file(&path, full_ld_suffixes[selected_linker], X_OK); === ERROR type #2: there should be exactly one space between function name and parenthesis (2 error(s)) === gcc/collect2.c:1135:34: ld_file_name = find_a_file(&cpath, ld_suffixes[selected_linker], X_OK); gcc/collect2.c:1140:23: find_a_file(&path, full_ld_suffixes[selected_linker], X_OK); === ERROR type #3: trailing operator (1 error(s)) === gcc/collect2.c:1139:21: ld_file_name = Note that I can't approve the patch, please wait for a reviewer that can approve it. Martin
