On 5/13/20 11:22 AM, Joel Brobecker wrote:
> Hello,
>
> Would someone mind reviewing this patch, please?
>
> The test explicitly uses -mvsx in the compilation options, so it seems
> reasonable to require powerpc_vsx_ok...
>
> Thank you!
You should always CC the PPC maintainers on PPC patches.
I've CC'd both Segher and David.
Peter
>> Just a friendly ping on the following patch, hopefully sufficiently
>> straightforward and tested to be allowed onto branch master.
>>
>>
>> On Fri, Apr 17, 2020 at 04:49:47PM -0700, Joel Brobecker wrote:
>>> From: Douglas Rupp <r...@adacore.com>
>>>
>>> Hello,
>>>
>>> (submitting this on behalf of Doug Rupp, one of my colleagues)
>>>
>>> We're getting an error when running this test on PowerPC VxWorks 7,
>>> due to an unexpected warning:
>>>
>>> | Excess errors:
>>> | cc1: warning: '-mvsx' and '-mno-altivec' are incompatible
>>>
>>> The warning comes from a combination of factors:
>>> - The test itself uses -mvsx explicitly via the following directive:
>>> // { dg-options "-O1 -mvsx" }
>>> - Our toolchain was configured so as to make -mno-altivec
>>> the default;
>>> - These two options are mutually exclusive.
>>>
>>> This commit adds a powerpc_vsx_ok dg-require-effective-target directive
>>> to that test, and thus making it UNSUPPORTED instead.
>>>
>>> Tested on PowerPC VxWorks 7. Also tested on PowerPC ELF as well,
>>> a platform where we do not make -mno-altivec the default, to verify
>>> that the test continues to run as usual in that case.
>>>
>>> gcc/testsuite/
>>>
>>> * gcc.target/powerpc/pr71763.c: Require powerpc_vsx_ok.
>>>
>>> OK for master?
>>>
>>> Thanks!
>>> --
>>> Joel
>>>
>>> ---
>>> gcc/testsuite/gcc.target/powerpc/pr71763.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/gcc/testsuite/gcc.target/powerpc/pr71763.c
>>> b/gcc/testsuite/gcc.target/powerpc/pr71763.c
>>> index b36ddfa26b0..b8888394393 100644
>>> --- a/gcc/testsuite/gcc.target/powerpc/pr71763.c
>>> +++ b/gcc/testsuite/gcc.target/powerpc/pr71763.c
>>> @@ -1,5 +1,6 @@
>>> // PR target/71763
>>> // { dg-do compile }
>>> +// { dg-require-effective-target powerpc_vsx_ok }
>>> // { dg-options "-O1 -mvsx" }
>>>
>>> int a, b;
>>> --
>>> 2.17.1
>>
>> --
>> Joel
>
