On Fri, May 15, 2020 at 12:53:41PM +0200, Tobias Burnus wrote:
> [Fortran] OpenMP 5 – permit more sharing clauses for SIMD (PR94690)
>
> gcc/fortran/
> PR fortran/94690
> * openmp.c (resolve_omp_do):
I'd hope Martin's script would reject such a commit. You didn't say what
you've changed.
> gcc/testsuite/
> PR fortran/94690
> * gfortran.dg/gomp/openmp-simd-4.f90: New test.
Otherwise LGTM, except that I think (but that can be done incrementally)
that it would be highly desirable to have also a runtime testcase that tests
the values after the loop when lastprivate or linear clauses are used
or are predetermined. Some of that is hopefully already in the testsuite
somewhere (the cases that were valid before), and one really can't test
after private (explicit or predetermined), because the value is undefined.
So that boils down to lastprivate on simd collapse(1) or simd without
collapse, and various kinds of do loops (step 1, -1, constant other,
variable), ideally some that can be actually vectorized. And that
test doesn't need to be in libgomp, but could be in gfortran.dg/vect/
with -fopenmp-simd.
Jakub
