"Yangfei (Felix)" <felix.y...@huawei.com> writes:
> Hi,
>
> Witnessed another ICE with option -mgeneral-regs-only.
> I have created a bug for that:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94991
>
> For the given testcase, we are doing FAIL for scalar floating move expand
> pattern since TARGET_FLOAT
> is false with option -mgeneral-regs-only. But move expand pattern cannot
> fail. It would be better to
> replace the FAIL with code that bitcasts to the equivalent integer mode,
> using gen_lowpart.
>
> Bootstrap and tested on aarch64-linux-gnu. Comments?
LGTM. Pushed with one minor formatting fix:
> @@ -1364,7 +1364,11 @@
> if (!TARGET_FLOAT)
> {
> aarch64_err_no_fpadvsimd (<MODE>mode);
> - FAIL;
> + machine_mode intmode
> + = int_mode_for_size (GET_MODE_BITSIZE (<MODE>mode), 0).require ();
The "=" should only be indented by two spaces relative to the first line.
Thanks,
Richard
