On Fri, May 08, 2020 at 08:17:18AM -0500, Bill Schmidt wrote:
> From: Kelvin Nilsen <kel...@gcc.gnu.org>
>
> Add support for new scalar instructions for counting leading or
> trailing zeros under control of a bitmask.
>
> Bootstrapped and tested on powerpc64le-unknown-linux-gnu with no
> regressions. Is this okay for master?
Ooh, I found problems!
> * config/rs6000/rs6000-builtin.def (__builtin_cntlzdm): New
> built-in function definition.
> (__builtin_cnttzdm): Likewise.,
Stray comma.
> +(define_insn "cntlzdm"
> + [(set (match_operand:DI 0 "gpc_reg_operand" "=r")
> + (unspec:DI [(match_operand:DI 1 "gpc_reg_operand" "r")
> + (match_operand:DI 2 "gpc_reg_operand" "r")]
> + UNSPEC_CNTLZDM))]
> + "TARGET_FUTURE && TARGET_64BIT"
> + "cntlzdm %0,%1,%2"
> + [(set_attr "type" "integer")])
TARGET_POWERPC64.
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/cntlzdm-0.c
> @@ -0,0 +1,57 @@
> +/* { dg-do compile } */
> +/* { dg-require-effective-target lp64 } */
And powerpc64 here as well then.
Not sure if this is a bigger problem than the comma thing though.
Segher
