On Mon, May 04, 2020 at 03:03:01PM +0200, Richard Biener wrote:
> We seem to have inconsistent use of rtx_equal_p vs. pointer comparison
> of target and ops[0].value - is that because some are eventually MEMs
> and some (targets?) are always registers? Of course I prefer the
> cheaper != comparison.
We don't know what exactly the target will be, pseudo is most likely, but
could be something else too.
And, rtx_equal_p starts with == comparison, so it is just the call overhead.
> Otherwise looks obvious to me, thus OK for trunk and branch (I don't
> see what it could break so from my side it would be OK for 10.1
> but let's ask Jakub).
I'm fine with it for 10.1, if the target is right, it won't do anything,
otherwise fix a wrong-code, and is limited to arm/aarch64 too (no other
target AFAIK has such ifns).
Jakub
