On Wed, Apr 29, 2020 at 11:48:51AM +0100, Richard Sandiford wrote:
> Jakub Jelinek <ja...@redhat.com> writes:
> > On Wed, Apr 29, 2020 at 10:57:24AM +0100, Richard Sandiford wrote:
> >> This patch makes the ABI code ignore zero-sized [[no_unique_address]]
> >> fields when deciding whether something is a HFA or HVA.
> >
> > As you use cxx17_empty_base_field_p, can you please remove the FIXME
> > in calls.h because it then can't go away, and perhaps update it to
> > test DECL_ARTIFICIAL (field) instead (or in addition to no attribute,
> > with with DECL_ARTIFICIAL first)?
>
> Sure, how's this? I added back the RECORD_OR_UNION_TYPE_P test too
> for good measure :-)
>
> Only lightly tested on aarch64-linux-gnu and aarch64_be-elf so far.
>
> Richard
>
>
> 2020-04-29 Richard Sandiford <richard.sandif...@arm.com>
>
> gcc/
> * calls.h (cxx17_empty_base_field_p): Turn into a function declaration.
> * calls.c (cxx17_empty_base_field_p): New function. Check
> DECL_ARTIFICIAL and RECORD_OR_UNION_TYPE_P in addition to the
> previous checks.
Ok, thanks.
Jakub
