Hi,
On Thu, 16 Apr 2020 at 09:50, Martin Liška <mli...@suse.cz> wrote:
>
> On 4/14/20 1:43 PM, Jakub Jelinek wrote:
> > Roughly, yes. A few extra in testcases don't hurt necessarily, but say 160
> > chars or more is clearly too much.
>
> All right, I made a limit of 120 characters for the changes.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed in next stage1?
This will introduce a regression on arm:
gcc.target/arm/armv8_2-fp16-move-1.c
Because of:
-/* { dg-options "-O2" } */
+/* { dg-options "-O2 -mfloat-abi=hard" } */
/* { dg-add-options arm_v8_2a_fp16_scalar } */
-/* { dg-additional-options "-mfloat-abi=hard" } */
Indeed arm_v8_2a_fp16_scalar inserts -mfloat-abi=softfp in some cases,
so the original version overrides it with -mfloat-abi=hard.
With your patch, the order is reversed, hence the error.
There may be similar problems on other targets?
Thanks,
Christophe
> Thanks,
> Martin
