Hi, David, > On Apr 24, 2020, at 5:36 PM, David Malcolm <dmalc...@redhat.com> wrote: > > On Fri, 2020-04-24 at 17:22 -0500, Qing Zhao wrote: >> Hi, Dave, >> >> Thanks a lot for the review and comments. >> I just updated the patch with all your suggestions, bootstrapped it >> and run regression test, no any issue. >> >> The newest patch is attached with this email. >> >> Richard/Jakub, please advise on whether I can commit this patch to >> Gcc10? >> >> Thanks a lot. >> >> Qing >> > > Thanks Qing. One more wording nit (sorry!) > >> + if (!flag_large_source_files) >> + inform (loc, >> + "adding %<-flarge-source-files%> will allow for more" >> + " column-tracking support, at the expense of compilation" >> + " and memory"); > ^^^^^^^^^^^^^ > Please add "time" here i.e. > " time and memory”);
Added it in my local directory. (And attached). Thanks. Qing
PR94230.patch
Description: Binary data
> > > Dave >
